NotionX / NotionX/react-notion-x

Documentation error on property name for including next/link component

Open
#453 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5.4k
Forks
645
PR merge metrics
No merged PRs in 30d

Description

Description

The example code shown in the readme for how to pass in a next/link component to the renderer has the property name NextLink. From looking at the source it appears this property name actually needs to be PageLink. Using the property NextLink doesn't seem to do anything.

https://github.com/NotionX/react-notion-x/blob/6493adc87a8f2dbb6b3881e27325a19501024789/readme.md?plain=1#L285

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at readme.md around line 285 and compare the documented property name with the renderer source referenced in the issue. Done when the example uses the property name that actually accepts the next/link component, and the README no longer shows NextLink.

Written by the indexing model from the issue text.

Assessment

Tech stack
nextjs, react, typescript
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.