NotionX / NotionX/react-notion-x
Embed without Embedly
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.4k
- Forks
- 645
- PR merge metrics
- No merged PRs in 30d
Description
Description
I would like to embed a Twitch clip, which requires providing the parent domain in the query params. When I set the parent to help.tangia.co, what's rendered on my notion site is https://player.twitch.tv/?channel=embed&muted=true&autoplay=false&parent=cdn.embedly.com, which prevents it from loading due to being the incorrect parent.
How can I prevent the embed from using the embedly CDN from within notion, or disable within the code?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Start by tracing the Twitch embed rendering path and how its parent query parameter is formed; done means the rendered URL preserves help.tangia.co and no longer substitutes cdn.embedly.com.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100