NotionX / NotionX/react-notion-x
Move header hash link to end of header text to avoid getting cut off on mobile
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.4k
- Forks
- 645
- PR merge metrics
- No merged PRs in 30d
Description
Description
When viewing on mobile, the header hash link gets cut off due to negative margin.
See screenshot below of this page in the test suite.
I think the easiest way to resolve this issue is to move the link icon to the end of the header rather than the beginning. This is the approach taken by a couple other websites I checked.
I'm happy to submit a PR if we're aligned on the approach!
Notion Test Page ID
https://react-notion-x-demo.transitivebullsh.it/0be6efce9daf42688f65c76b89f8eb27
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the header rendering entry point used for the linked Notion test page and reproduce the mobile screenshot at https://react-notion-x-demo.transitivebullsh.it/0be6efce9daf42688f65c76b89f8eb27. Verify the hash link is positioned at the end of the header text and is no longer cut off on mobile.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100