NotePlan / NotePlan/plugins

Link to create meeting note doesn't create link to event or allow reloading of note once created

Open
#524 10 comments 0 reactions 1 assignee View on GitHub

@EduardMe is already working on this.

Since Feb 7, 2024.

bug
Dominant language
JavaScript
Stars
204
Forks
82
Avg merge
22h 27m
Merged PRs (30d)
3

Description

Describe the bug
After inserting a list of events using the "insert todays events as list" command, the Meeting Note link will indeed create a new note, but it is not linked to the calendar event. Going back to the Meeting Note link on the calendar page will load the created note but instead will offer to create a new one. If I do this, it realizes the note already exists and gives me various options.

To Reproduce
Steps to reproduce the behavior:

  1. Go to today's daily note
  2. run the "Insert today's events as list" command (the same problem occurs if invoking via a template (My Events List display format is - |START| |TITLE| |EVENTLINK| |MEETINGNOTE|; sort order of events is time, Calendars to include is "Calendar" (which is an Exchange calendar); Meeting Note Template title is blank)
  3. Click on Meeting Note link - I am prompted to create a select a template - I do this and the Note loads
  4. Return to daily note
  5. Click on same Meeting Note link
  6. I again am given the prompt to select a template
  7. The note loads, but I get a warning that the note already exists and am given the option to open existing note, prepend, append, or create a new note with the same name.

Expected behavior
After Step 5, I expected the note I created in step 3 to load without prompting for a template or warning that the note already exists.

Screenshots
If applicable, add screenshots to help explain your problem.

System

  • Device: Mac
  • OS: MacOS 14.3
  • NotePlan Version 3.9.12 (1151)
  • Event Helpers v0.21.0

Additional context
I'm thinking the issue is that the event ID's don't match between the event and the Meeting Note links:

Event link in today's note
![📅](2024-01-31 08:00:::E5FD21CC-5DB5-4E77-9C9D-6499183F9365/RID=728398800:::NA:::ClinOps/ CR AGT :::#1BADF8)

Event link in meeting note (the same)
![📅](2024-01-31 08:00:::E5FD21CC-5DB5-4E77-9C9D-6499183F9365/RID=728398800:::NA:::ClinOps/ CR AGT :::#1BADF8)

Link to Meeting Note in Event List
Meeting Note

Plugin Console Log
To provide us with more clues about where the bug/error is occurring...

  1. Open the Plugin's Preferences by going to NotePlan's menu > Preferences > Plugins and clicking the settings "cog" icon next to the plugin in question. Scroll to the bottom and set the logging level to "DEBUG" and click "Save & Close"
  2. Now open the Plugin Console by going to Noteplan > Help > Plugin Console
  3. Run the plugin command you're reporting
  4. Copy the output from the Plugin Console and paste it below
  5. Delete any output that has personal information you don't want in there
Executing function 'insertDaysEvents'
2024-01-31 08:42:07 | DEBUG | jgclark.EventHelpers v0.21.0 :: insertDaysEvents: Starting
2024-01-31 08:42:07 | DEBUG | jgclark.EventHelpers v0.21.0 :: listDaysEvents: starting for date 20240131 with paramString=''
2024-01-31 08:42:07 | DEBUG | jgclark.EventHelpers v0.21.0 :: Start of getEventsSettings()
2024-01-31 08:42:07 | DEBUG | tempTimeOptions:  :: {
  "minute": "2-digit",
  "hour12": true,
  "hour": "2-digit"
}
2024-01-31 08:42:07 | DEBUG |  :: [Calendar]
2024-01-31 08:42:07 | DEBUG | NPCalendar / getEventsForDay :: - 6 of 10 Events kept for 20240131 after filtering with Calendar
2024-01-31 08:42:07 | DEBUG | listDaysEvents :: - 6 events found on 20240131 from  1 calendars Calendar
2024-01-31 08:42:07 | DEBUG | listDaysEvents :: - Processing event 'REDACTED1 ' (object)
2024-01-31 08:42:07 | DEBUG | listDaysEvents :: - Processing event 'REDACTED2' (object)
2024-01-31 08:42:07 | DEBUG | listDaysEvents :: - Processing event 'REDACTED3' (object)
2024-01-31 08:42:07 | DEBUG | listDaysEvents :: - Processing event 'REDACTED4' (object)
2024-01-31 08:42:07 | DEBUG | listDaysEvents :: - Processing event 'REDACTED5' (object)
2024-01-31 08:42:07 | DEBUG | listDaysEvents :: - Processing event 'REDACTED6' (object)
2024-01-31 08:42:07 | DEBUG | listDaysEvents :: ## Events
- 08:00 AM REDACTED1  ![📅](2024-01-31 08:00:::E5FD21CC-5DB5-4E77-9C9D-6499183F9365/RID=728398800:::NA::: REDACTED1 :::#1BADF8) [Meeting Note](noteplan://x-callback-url/runPlugin?pluginID=np.MeetingNotes&command=newMeetingNoteFromEventID&arg0=7450A589-933C-44AA-A2A1-416636A38A72&arg1=)
- 09:00 REDACTED2 ![📅](2024-01-31 09:00:::E3DB0622-744F-4935-90ED-EB2FD85925F7/RID=728402400:::NA:::REDACTED2:::#1BADF8) [Meeting Note](noteplan://x-callback-url/runPlugin?pluginID=np.MeetingNotes&command=newMeetingNoteFromEventID&arg0=6F480898-6A37-4EFF-8B10-E014CE9DBD85&arg1=)
- 12:00 PM REDACTED3 ![📅](2024-01-31 12:00:::6E4F9A93-BB9A-4125-8E78-12A9A66A51AF:::NA::: REDACTED3:::#1BADF8) [Meeting Note](noteplan://x-callback-url/runPlugin?pluginID=np.MeetingNotes&command=newMeetingNoteFromEventID&arg0=DC31BF30-B280-4C72-AD71-1F24147BBA6B&arg1=)
- 01:30 PM REDACTED4  ![📅](2024-01-31 13:30:::212D34EE-04B1-423A-B6FC-A661E6393302:::NA::: REDACTED4 :::#1BADF8) [Meeting Note](noteplan://x-callback-url/runPlugin?pluginID=np.MeetingNotes&command=newMeetingNoteFromEventID&arg0=0DA4F42E-48D1-4AA2-BDD0-52FC8F94C710&arg1=)
- 02:30 PM REDACTED5 ![📅](2024-01-31 14:30:::BFE1800E-DE6A-41B5-8762-EC44AF7C66D0/RID=728330400:::NA::: REDACTED5:::#1BADF8) [Meeting Note](noteplan://x-callback-url/runPlugin?pluginID=np.MeetingNotes&command=newMeetingNoteFromEventID&arg0=5DA66D79-49CE-47F8-8D92-58D9654ABA05&arg1=)
- 04:30 PM REDACTED6 ![📅](2024-01-31 16:30:::007E4092-B377-43C4-98A1-4D70B300AFEF:::NA::: REDACTED6:::#1BADF8) [Meeting Note](noteplan://x-callback-url/runPlugin?pluginID=np.MeetingNotes&command=newMeetingNoteFromEventID&arg0=1279A67A-DB19-41E0-815B-9E4A708B26C0&arg1=)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.