NotePlan / NotePlan/plugins

Smarter share sheet to avoid breaking triggers

Open
#415 0 comments 0 reactions 1 assignee View on GitHub

@EduardMe is already working on this.

Since Mar 4, 2023.

bug
Dominant language
JavaScript
Stars
204
Forks
82
Avg merge
22h 27m
Merged PRs (30d)
3

Description

There are existing Canny requests with ideas about making more of the share sheet extension.
But I'm coming at it here from the plugin perspective, as another knock-on from the introduction of triggers, which necessitate more use of frontmatter, even in daily notes. (#411 is another recent example.)

Currently: the only option from the share sheet extension is to prepend text to a daily note.
Issue: this then stops frontmatter from being frontmatter, stopping triggers from working. Hence this is now closer to a Bug than a Feature Request.

Ideal solution: be smarter at where to insert the text. For nearly 2 years now my plugins, calculate a smart insertion point that comes after any H1 title and initial preamble, and now after any frontmatter too. If you want to see the logic, it's in helpers/paragraph.js::calcSmartPrependPoint.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.