np.Templating: date.add and subtract and business add API/docs need normalization
Open
@mikeerickson is already working on this.
Since Feb 1, 2023.
- Dominant language
- JavaScript
- Stars
- 204
- Forks
- 82
- Avg merge
- 22h 27m
- Merged PRs (30d)
- 3
Description
See the discussion here
date.add documentation is wrong
but even if the docs were right, the API would not be consistent with businessadd
Documentation:
Note how pivotDate is in a different location for the two groups below.
Actual code in DateModule.js
add(userPivotDate = '', value = '', shorthand = 'days', format = '') {
subtract(userPivotDate = '', value = '', shorthand = 'days', format = '') {
businessAdd(numDays = 1, pivotDate = '', format = '') {
businessSubtract(numDays = 1, pivotDate = '', format = '') {
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.