NotePlan / NotePlan/plugins

Q: How to get editor when HTML window has focus

Open
#373 2 comments 0 reactions 1 assignee View on GitHub

@EduardMe is already working on this.

Since Dec 4, 2022.

API question UI
Dominant language
JavaScript
Stars
204
Forks
82
Avg merge
22h 27m
Merged PRs (30d)
3

Description

In Reviews plugin, I now have a set of action buttons at the top:
CleanShot 2022-12-04 at 23 24 54@2x

Most trigger opening a different note in the Editor, for the user to do work on.
However the 'Complete' and 'Toggle Pause' buttons want to do work on whatever is open in the Editor. The problem is that when the HTML window has the focus -- as it always has when you have clicked the button -- the Editor is then null.

I'm 99% sure this worked 6+ weeks ago. But I'm treating this as a question, not a bug, as it may uncover a deeper architectural question which we want to consider. But assigning to @EduardMe to see what he thinks should be happening at the moment.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.