NotEnoughUpdates / NotEnoughUpdates/NotEnoughUpdates-REPO

Add maxLevel to enchants.json and minor updates

Open
#2,311 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
292
Forks
164
Avg merge
4h 4m
Merged PRs (30d)
80

Description

Sorry for wasting your time with the prior PR. I thought ill just open an Issue too properly share my idea and I can make another quality PR if you agree:

I want to add a way of obtaining the maxLevel of an item (any means) from the repo. I have 2 ideas for this:

Idea 1: Updating enchants_xp_cost then using its lenght

To do this we'd update enchants_xp_cost to the values of the Combining Costs* table on the offiicial Wiki.
Example of an already correct entry in the dict: habanero_tactics": [ 0, 0, 0, 250, 300 ],
Currently some enchantments (for example: "the_one": [ 250, 300 ],) do not have "leading" zeros as placeholders. Currently none enchantments have "trailing" zeros ("efficiency": [ 10, 15, 20, 25, 30, 0, 0, 0, 0, 0 ],)

Example usage in Firmament: RepoManager.enchantData.allEnchants?.enchantExperienceCost?.mapValues { it.value.size }?: emptyMap() (RepoManager is a object which gets data from this repo)

*The Combining Cost dict is called enchants_xp_cost in the json, but also provides combining costs for non E-Table enchants. This is confusing, as not every combining cost equals the enchanting cost

Idea 2: Add a "maxLevel" key that has the same structure as "max_xp_table_levels"

(should be obvious)

The cleanest would probably to add the first for consistency and the second for intuitive usage.


I also found outdated data in the file:

Missing in enchants_xp_cost:
https://wiki.hypixel.net/Green_Thumb_Enchantment

Outdated enchants_xp_cost :
https://wiki.hypixel.net/Impaling_Enchantment
https://hypixel-skyblock.fandom.com/wiki/Divine_Gift

Missing in max_xp_table_levels:
aiming, blessing, fire_aspect, flame, impaling, knockback, piercing, punch, rainbow, snipe

Missing in enchants:
SHEARS

Missing in enchant_pools (probably/maybe not complete):
Axe Ultimate Enchants, The new Turbo Books, One for all with Champion and Divine Gift

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting enchants.json, especially enchants_xp_cost, max_xp_table_levels, enchants, and enchant_pools, then compare the listed missing or outdated entries with the linked wiki pages. Confirm which max-level representation maintainers want before editing. Done means the chosen max-level data is consistent and all listed missing or outdated entries are reviewed and updated.

Written by the indexing model from the issue text.

Assessment

Tech stack
json
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.