NotEnoughUpdates / NotEnoughUpdates/MoulConfig
Search tag concatenation bug
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 22
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Description
Currently, Search Tags are implemented using string concatenation on the tag instance itself rather than its value which is likely a mistake and means that any manual implementations of Search Tags must override the toString value to return the tag value itself in order for them to work.
MoulConfig should concatenate the actual tag value instead as that's more expected and the current behaviour relies on JVM implementation details to function correctly (as per the JDK 21 JavaDoc on Annotation#toString).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate where MoulConfig builds Search Tag strings and trace how the tag instance is concatenated. Update the behavior so concatenation uses the tag value rather than relying on Annotation#toString, then run the relevant existing tests or reproduce a manual Search Tag without a custom toString implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- search
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100