NotASithLord / NotASithLord/peerd

page.goto returns a null URL after successful navigation

Open
#453 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
410
Forks
45
Avg merge
11d 5h
Merged PRs (30d)
1

Description

Problem

page.goto() reads url from the successful navigate result. The tool returns finalUrl. The call therefore returns url: null, including after a redirect.

Expected

  • Return the final landed URL.
  • Keep failed and refused navigation behavior unchanged.
  • Cover the real navigate result shape with a regression test.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the page.goto implementation and trace how it reads the successful navigate result, then inspect the existing navigation tests. Reproduce the real result shape where the final URL is returned as finalUrl, add a regression test, and verify that successful navigation returns the landed URL while failed and refused navigation behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.