NotASithLord / NotASithLord/peerd

page.click reports successful selector clicks as false

Open Beginner friendly
#450 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
410
Forks
45
Avg merge
11d 5h
Merged PRs (30d)
1

Description

The page API converts clicked to true only for the literal Boolean true. The selector scripting path returns the clicked selector string after a successful action. The page API therefore reports a completed click as clicked:false. Generated browser code can retry a purchase, send, or form submission.

Expected behavior:

  • Any successful click tool result maps to clicked:true.
  • Failed click results still reject.
  • The contract test uses the real selector result shape.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the page API click handling and trace the selector scripting path, then run the contract test using the real selector result shape. Done means every successful click result is reported as clicked:true, failed results still reject, and the contract test passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing-qa, web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.