Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine

[Change Requests] - Remove leadership change requests

Open
#4,460 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
36
Forks
9
Avg merge
4d 21h
Merged PRs (30d)
11

Description

Description
Context

Leadership CRs (CR_Type.LEADERSHIP) are being removed as part of phasing out auto-implementing CR types. The creation path (createLeadershipChangeRequest / applyLeadershipChangeRequest) needs to go, along with references to LEADERSHIP in reviewer-queue filtering. Since CR_Type is a Postgres enum and historical rows will already have type: LEADERSHIP, the enum value and the Leadership_CR model must stay for historical/audit purposes only the ability to create new ones is being removed.

Task

Remove createLeadershipChangeRequest and applyLeadershipChangeRequest. Remove CR_Type.LEADERSHIP from the exclusion filter in getToReviewChangeRequests and from the OR clause in getApprovedChangeRequests. Remove any routes, frontend entry points, and shared-type references used to create a leadership CR. Do not remove the LEADERSHIP enum value or the Leadership_CR model/relations leave those intact for historical reads.

Acceptance Criteria
  • No route or UI path exists to create a new leadership CR.
  • Existing leadership CRs still display correctly wherever CR history is shown.
  • getToReviewChangeRequests and getApprovedChangeRequests no longer reference CR_Type.LEADERSHIP in dead filter branches.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search for createLeadershipChangeRequest, applyLeadershipChangeRequest, CR_Type.LEADERSHIP, and the getToReviewChangeRequests and getApprovedChangeRequests entry points, then trace their routes, frontend entry points, and shared types. Done means creation paths and dead filter references are removed while the LEADERSHIP enum value, Leadership_CR model and relations, and historical displays remain intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgresql, typescript
Domain
backend, database, frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.