Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine

[Change Requests] -Wrap CR review-and-apply flow in transactions

Open
#4,459 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
36
Forks
9
Avg merge
4d 21h
Merged PRs (30d)
11

Description

Description
Context

In reviewChangeRequest, the change request is marked accepted/dateReviewed in one Prisma call, then a separate method (reviewStageGateChangeRequest, reviewActivationChangeRequest, or reviewBudgetChangeRequest) actually applies the change. If that second step throws reviewStageGateChangeRequest's "Date completed cannot be before the work package start date" check the CR is left marked as accepted/reviewed even though nothing was actually applied, and the if (foundCR.accepted) throw guard means it can never be retried or reviewed again. applyLeadershipChangeRequest already does this correctly with prisma.$transaction and can be used as the reference pattern.

Task

Wrap reviewChangeRequest's update and its dispatch to reviewStageGateChangeRequest / reviewActivationChangeRequest / reviewBudgetChangeRequest / reviewStandardChangeRequest in a single prisma.$transaction. Each of those four methods' internal multi-step writes (change.createMany followed by a separate entity update) also needs to happen inside that same transaction.

Acceptance Criteria

If any step in the apply flow throws, no partial state is persisted the CR is left exactly as it was before review was attempted (still unreviewed, still reviewable).
A CR can never end up accepted: true / dateReviewed set without its corresponding changes having actually applied.
Existing successful review flows (stage gate, activation, budget, standard) behave identically to before.

Proposed Solution

...

Mocks

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at reviewChangeRequest and trace its dispatch to reviewStageGateChangeRequest, reviewActivationChangeRequest, reviewBudgetChangeRequest, and reviewStandardChangeRequest. Read applyLeadershipChangeRequest first for the existing prisma.$transaction pattern, then inspect each method's multi-step writes. Done means failed applies leave the CR unreviewed and successful stage gate, activation, budget, and standard reviews behave as before.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend, database
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.