Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine

[Maintenance] - Fix Horizontal Stretch for Pages With Sidebar Opened

Open
#4,418 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

maintenance
Dominant language
TypeScript
Stars
36
Forks
9
Avg merge
4d 21h
Merged PRs (30d)
11

Description

Description

There is, on rare occurrence (depending on what page you are on), an issue where the right main page prop stretches into the right side causing a scroll frame to occur, therefore not fitting the page length to the window size:

Image

As seen above, this happens regularly with the Gantt Chart page and is easily reproducible there.

On the not so easily reproducible side, it happens also on the Calendar page as seen below:

Image Please remember that this primarily happens when the sidebar is already opened and there is a switch to another page (as far as my testing can tell).
Acceptance Criteria
  • Find the root cause on why the pages are being stretched beyond the space that is left after the sidebar is opened (that means clicking the arrow to open the sidebar, not hovering to open the sidebar)
  • Do not scope your acceptance to just the Gantt and Calendar. This goes for ALL pages on the sidebar. (This should be pretty straightforward. If it works for one, it most likely will work for all the others. Do not forget to check though).
  • Ensure it does not occur at all through a final test of all pages
Proposed Solution
  • Find the parent prop for all other descendant pages. This is most likely a top level component that from the looks of it renders CSS to make it so it fits to whatever room is left AFTER the sidebar is opened. (AppAuthenticated.tsx)
  • Try different CSS to see if it improves. Work towards modernizing it if it uses legacy/improper use of CSS.
Mocks

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with AppAuthenticated.tsx and reproduce the horizontal stretch with the sidebar opened, especially when switching to the Gantt Chart and Calendar pages. Inspect the parent layout props and CSS that size descendant pages, then verify every sidebar page fits the remaining window width without a horizontal scroll frame.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.