Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine

[Change Requests] - Change the Activate modal's submit button to "Submit CR" for far-off dates

Open
#4,417 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
36
Forks
9
Avg merge
4d 21h
Merged PRs (30d)
11

Description

Description

Context
When someone activates a work package with a start date far from its scheduled start date, that's a bigger deal than a small adjustment, and we want the button to signal it. If the chosen start date is outside the allowed buffer window, the modal's submit button should read "Submit CR" instead of "Submit." Inside the window, it stays "Submit." This is a label change only.

Task
Make the Activate modal's submit button label switch between "Submit" and "Submit CR" based on how far the chosen start date is from the work package's scheduled start date.

Acceptance Criteria
  • The modal knows the work package's scheduled start date and the org's configured buffer days.
  • When the selected start date is outside the buffer (before or after), the submit button reads "Submit CR."
  • When it's within the buffer, the button reads "Submit."
  • The label updates live as the user changes the date in the picker.
  • This is presentation only; no change to what gets submitted.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Activate modal and trace how the date picker exposes the selected start date, the work package's scheduled start date, and the organization's buffer days. Update the presentation label so it changes live between "Submit" and "Submit CR" for dates outside or inside the buffer, without changing submission behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.