Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine
[Maintenance] - No Car filter on Reimbursement Requests Page
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 36
- Forks
- 9
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 11
Description
Description
We want to remove the car filtering from the reimbursement requests page, so that users can view all requests at once, regardless of which car they have selected.
Acceptance Criteria
- reimbursement requests page does not filter by car, and shows all reimbursement requests
Proposed Solution
- update backend endpoints (getCurrentUserReimbursementRequests, getCurrentUserAssignedReimbursementRequests, getCurrentUsersTeamsReimbursementRequests, getAllReimbursementRequests) to remove carNumber parameter (reimbursement-requests.service and controller)
- update corresponding hooks (finance.hooks.ts) to no longer use carNumber
Mocks
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the reimbursement-requests.service and controller endpoints named in the issue, then inspect finance.hooks.ts to trace how carNumber is passed through. Remove the car-based filtering across these endpoints and hooks, and verify that the reimbursement requests page shows all requests regardless of the selected car.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100