Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine
[Maintenance] - Clear Form State only on Cancel
Open
@vijayab2029 is already working on this.
Since Jul 30, 2026.
maintenance
stale
- Dominant language
- TypeScript
- Stars
- 36
- Forks
- 9
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 11
Description
Description
When you click outside a task (or hit escape), our NERModal closes and the form resets, same as hitting cancel button. This keeps happening by accident. Form state shouldn't clear unless the user explicitly clicks 'cancel'.
Acceptance Criteria
- clicking outside the modal or pressing escape no longer closes it or clears the form; only clicking cancel does
Proposed Solution
- in NERModal.tsx, change Dialog's onClose={onHide} to receive (event, reason) and ignore backdropClick/escapeKeyDown instead of always calling onHide
Mocks
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.