Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine

[Maintenance] - Deleted Projects Show on Retro

Open
#4,345 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

maintenance
Dominant language
TypeScript
Stars
36
Forks
9
Avg merge
4d 21h
Merged PRs (30d)
11

Description

Description

Can we make it so that deleted projects still show up in the retro (or make it so that you can only archive projects that have fully stage gate completed work packages)?

Acceptance Criteria
  • deleting a project no longer strips its work packages from the retro, deleted projects still show their full historical timeline/budget data
Proposed Solution
  • reproduce: delete a project with work packages, confirm it shows up empty/stripped in the retro
  • getProjectQueryArgs in projects.query-args.ts filters workPackages by wbsElement.dateDeleted: null, which getRetrospectiveTimelines/getRetrospectiveBudgets (retrospective.services.ts) reuse, this is why deleted work packages vanish from retro data
    • add a separate query args function for retro that doesn't filter out deleted work packages, and use it in getRetrospectiveTimelines/getRetrospectiveBudgets instead of getProjectQueryArgs
Mocks

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in projects.query-args.ts and retrospective.services.ts. Reproduce the issue by deleting a project with work packages, then trace how getProjectQueryArgs filters workPackages by wbsElement.dateDeleted and how the retrospective timeline and budget functions reuse it. Done means deleted projects retain their full historical timeline and budget data in the retro.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.