Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine

[Maintenance] - Retrospective End Date/Dropped WP Bugs

Open
#4,344 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

maintenance
Dominant language
TypeScript
Stars
36
Forks
9
Avg merge
4d 21h
Merged PRs (30d)
11

Description

Description

The retrospective doesn't do its job. Changing the point of retro (date) doesn't do anything, and what currently fills out is random and not right, and is missing some work packages.

Acceptance Criteria
  • changing the retro start/end date actually changes what shows in the retrospective view
  • the retrospective correctly reflects every project's real work packages, with no missing or incorrect entries
Proposed Solution
  • Add the missing end date picker to Restrospective.tsx. Currently, its headerRight only renders one DatePicker bound to startDate, even though RetroGanttFilters/buildRetroGanttParams (gantt.utils.tsx) already support endDate
  • Fix the case bug at retrospective.services.ts:39 — change.detail.toLowerCase().includes('Added duration') compares a lowercased string against 'Added duration' (capital A), so that branch never matches; should be 'added duration'
  • Work packages blocked by something outside the queried set get silently dropped; check getBlockingGanttTasks in gantt.utils.tsx
Mocks

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading Retrospective.tsx and the existing RetroGanttFilters/buildRetroGanttParams flow in gantt.utils.tsx to trace how the retrospective dates reach the view. Then inspect retrospective.services.ts:39 and getBlockingGanttTasks in gantt.utils.tsx; verify that changing both dates produces the expected project work packages, including items blocked outside the queried set.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.