Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine

[Maintenance] - Calendar All Day Events Notif Fix

Open
#4,108 0 comments 0 reactions 1 assignee View on GitHub

@vfobid is already working on this.

Since Apr 2, 2026.

back-end maintenance stale straightforward
Dominant language
TypeScript
Stars
36
Forks
9
Avg merge
4d 21h
Merged PRs (30d)
11

Description

Description

Checking "All Day" on the calendar incorrectly sets the time in the Slack notification to 12pm. Update to say "is today"

Acceptance Criteria
  • test ss in #slackbot_land showing "is today" for an all day event
Proposed Solution

src/backend/src/services/notifications.services.ts - update the timeDisplay to use "is today" instead of the earliestSlot value for all day events

Events have Schedule slots which have an all day boolean to check for

Screenshots
Image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.