Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine

[Maintenance] - Frontend Move Notifications to Event Level

Open
#4,092 0 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

front-end maintenance stale
Dominant language
TypeScript
Stars
36
Forks
9
Avg merge
4d 21h
Merged PRs (30d)
11

Description

Description

We want users to be able to toggle notifications at the event level. Currently this is controlled at the Event Type level through admin tools.

Remove 'Send Slack Notifications' from Admin Tools event type forms and add a toggle to the Event create and edit forms so users can control Slack notifications per event.

Blocked by the backend changes in #4090

Proposed Solution

  • remove checkbox from admin tools EventTypeFormModal and EditEventTypeModal
  • add toggle to event create form & event edit form (constrained by the same !teams && !workPackage disable logic that currently lives in the event
    type form)
    • apply same disable logic currently used in the event type form: disable and default to false when neither teams nor work
      packages are selected for the event
  • update hooks to remove sendSlackNotifications from Event Type and move to Event paths
  • update any types that reference EventType.sendSlackNotifications
Acceptance Criteria
  • screenshots of calendar event create/edit modals w/ toggle
  • screenshots of admin tools edit event type modal w/o checkbox
Screenshots
Image Update the notification value to a toggle in the Edit/Create Event modals
Image Remove send slack notifications toggle from admin tools

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.