Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine
[Maintenance] - Frontend Move Notifications to Event Level
Open
Nobody has claimed this yet.
front-end
maintenance
stale
- Dominant language
- TypeScript
- Stars
- 36
- Forks
- 9
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 11
Description
Description
We want users to be able to toggle notifications at the event level. Currently this is controlled at the Event Type level through admin tools.
Remove 'Send Slack Notifications' from Admin Tools event type forms and add a toggle to the Event create and edit forms so users can control Slack notifications per event.
Blocked by the backend changes in #4090
Proposed Solution
- remove checkbox from admin tools EventTypeFormModal and EditEventTypeModal
- add toggle to event create form & event edit form (constrained by the same !teams && !workPackage disable logic that currently lives in the event
type form)- apply same disable logic currently used in the event type form: disable and default to false when neither teams nor work
packages are selected for the event
- apply same disable logic currently used in the event type form: disable and default to false when neither teams nor work
- update hooks to remove sendSlackNotifications from Event Type and move to Event paths
- update any types that reference EventType.sendSlackNotifications
Acceptance Criteria
- screenshots of calendar event create/edit modals w/ toggle
- screenshots of admin tools edit event type modal w/o checkbox
Screenshots
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.