Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine
[Maintenance] - Reimbursement Request Bug
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 36
- Forks
- 9
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 11
Description
Description
In the #finance Slack channel, some reimbursement requests are not properly linking to the Finishline reimbursement request.
An admin role should be able to view any rr, so this shouldn't be a permission issue. Potentially the requestId value that creates the link to the rr page is edited after creation.
Notes
- Finance team member → can view ANY RR
- Head/Admin → can view ANY RR
- RR creator (recipientId matches) → can view their OWN RR only
- Everyone else → AccessDeniedException
This will be difficult to test with your personal finishline account as a member (non head/admin/finance member) because all rrs in the slack channel will throw AccessDeniedException and not show. Testing should be sent to #slackbox_land channel and test viewing different rrs as an admin role to see if we can reproduce this error
Proposed Solution
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace the Slack reimbursement flow and the requestId used to build the Finishline RR link; compare it with the stored request after creation and the documented role rules. Reproduce the problem in #slackbox_land as an admin with multiple RRs, then verify that valid links resolve and authorized roles can view them without AccessDeniedException.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, authorization, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100