Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine
[Change Requests] - Paginate getAllChangeRequests
Open
Nobody has claimed this yet.
difficult
technical improvement
- Dominant language
- TypeScript
- Stars
- 36
- Forks
- 9
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 11
Description
Description
Right now there are alot of change requests. So a web request to get them pulls alot of data and takes on the order of seconds no matter the internet connection.
Acceptance Criteria
- It only fetches change requests it needs to show
- Filtering still works
Proposed Solution
- Paginate the getAllChangeRequests API such that the client can pass in the number of change rquests it wants to fetch.
- Somehow dont break filtering? This might mean filtering has to be server-side which leads to more requests for sure. Maybe upon loading the projects page the first [rowsPerPage] change requests with the given filter can be called, then all other change requests can be fetched asynchronously in the background.
Mocks
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace getAllChangeRequests from the API to the projects page, including the rowsPerPage value and existing filtering behavior. Start by identifying where requests are fetched and filtered, then verify that pagination limits the initial data and filtering still returns the correct change requests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, full-stack
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100