Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine
[Bug] - Edit Reimbursement Request is false triggering Reimbursement Request Creation Slack Notif
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 36
- Forks
- 9
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 11
Description
Description
Edits on an existing request with a new receipt being uploaded when all previous receipts were deleted is false triggering the slack notification for creating reimbursement requests
Acceptance Criteria
There should be no slack notification.
Proposed Solution
The slack notification is being created in the backend, so find out why it is being called in the scenario mentioned above.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the backend path that creates the Slack notification for reimbursement requests, then reproduce editing an existing request after deleting all previous receipts and uploading a new one. Trace why the creation notification is called during that edit flow; done means the scenario produces no Slack notification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100