Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine

Finance - Ability to record discounts on purchases

Open
#2,647 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

new feature
Dominant language
TypeScript
Stars
36
Forks
9
Avg merge
4d 21h
Merged PRs (30d)
11

Description

Current Features

Currently, reimbursement requests are broken down by line item, with the price for each item purchased recorded. The total is determined by the sum of the parts purchased. If an entire order was purchased at a discount, the only way to record this is to drop the price of a single item, which messes up record keeping.

Desired Additional Features

We want to add the ability to record a general discount on an order.

This will involve adding a discount field to the reimbursement requests form, then modifying the reimbursement requests endpoint to allow for the discount value to be passed to the backend. The discount field should accept a dollar amount.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the reimbursement requests form and the reimbursement requests endpoint, then trace how line-item prices are currently collected and sent. The work is done when the form accepts a dollar-value general discount and the endpoint passes that discount to the backend for an order.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend-api-design, full-stack
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.