Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine

DRC Debugs - Actively query for unconfirmed DRs

Open
#2,592 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

front-end medium
Dominant language
TypeScript
Stars
36
Forks
9
Avg merge
4d 21h
Merged PRs (30d)
11

Description

Description

Right now the only way to confirm your availability for a design review is to click the slack link which takes you to the settings page and opens the modal. If slack or the link messes up, someone is unable to confirm their availability. Therefore, we want to actively check for unconfirmed design reviews on the home page, and pop open the confirm design review availability modal if the current user has any they need to confirm.

Acceptance Criteria
  • Any unconfirmed design reviews for a user will cause a confirm availability modal to pop up when they enter the home page on FinishLine.
  • If the user clicks cancel on the modal, it should close the modal, but reopen it if they come back to the page
  • If the user submits, it should call the mark user confirmed endpoint like the current modal does now
Proposed Solution

You should be able to reuse the confirm design review availability modal we currently have, the trickiness from this one is going to come from determining on which design reviews a user is in the list of required members on a design review but not the list of confirmed members.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing confirm design review availability modal and the mark user confirmed endpoint, then trace how the home page loads design reviews. Determine how to identify users in required members but not confirmed members. Done means the modal appears for qualifying users, canceling allows it to reappear on return, and submitting uses the existing endpoint.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
full-stack
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.