Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine
DRC Debugs - Message Should be Updated/ Thread Pinged if DR is edited after finalizing
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 36
- Forks
- 9
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 11
Description
Description
If a design review is edited after it's been finalized we need to change several things. The finalize button should now say edit on the design review detail page (make sure the modal matches).
You should also update the design review edit endpoint to make sure the original slack message is updated again with any updated details if a design review is edited after being scheduled, and you should send a new message to the thread each time it's been edited after finalizing that says: "The details of the design review have been updated!"
Acceptance Criteria
- See Above
Proposed Solution
Ask questions if you're confused about the slack code in the backend, the change itself shouldn't be complicated, but understanding/ testing the slack code might be confusing.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the design review detail page and its modal, then trace the design review edit endpoint and the existing Slack message and thread handling. Done means the finalized control changes to Edit, edited scheduled reviews update the original message, and each post-finalization edit sends the specified thread message.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend, full-stack
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100