Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine
DRC Debugs - Enforce not being able to edit anything once a DR is complete
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 36
- Forks
- 9
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 11
Description
Description
We want to disable editing on a design review once it has been marked as complete so it can act as a log of the meetings we've had about a work package. This ticket is to add a check to the backend endpoint and the button in the frontend modal that takes you to the edit page to enforce this.
Acceptance Criteria
- The edit design review endpoint throws an error if you try to edit a completed design review
- The edit button is greyed out on a design review pop up if the design review has been marked as completed
Proposed Solution
Look at other examples of permission checks in the code
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the design review edit endpoint and the frontend modal containing the edit button, then inspect other permission checks as suggested by the issue. Done means completed design reviews reject edit requests and show a disabled edit button in the popup; no specific files or tests are named.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- full-stack
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100