Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine
ReviewChangeRequestsView should use an NERFormModal
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 36
- Forks
- 9
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 11
Description
Description
Right now a lot of places use the default Dialog component for a modal instead of the styled NERModal that we've created. This ticket is to replace the use of the MUI dialog with the NERFormModal component in the ReviewChangeRequestsView component.
Acceptance Criteria
- All use of the dialog component is removed from ReviewChangeRequestsView
- The NERFormModal Component is used instead
- All functionality is unaffected
Proposed Solution
See how we've used the NERFormModal elsewhere for examples
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate ReviewChangeRequestsView and inspect how it currently uses the MUI Dialog. Read examples elsewhere that use NERFormModal, then replace the dialog usage while preserving all existing functionality. Done means ReviewChangeRequestsView no longer uses Dialog and its modal behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100