Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine

Slack - Reimbursement Requests Should Have Reaction Messages

Open
#2,489 0 comments 0 reactions 1 assignee View on GitHub

@Aaryan1203 is already working on this.

Since May 24, 2024.

back-end difficult stale
Dominant language
TypeScript
Stars
36
Forks
9
Avg merge
4d 21h
Merged PRs (30d)
11

Description

Description

Right now Change Requests get a check mark/ x emoji when it's approved or denied. We want to implement a similar functionality for reimbursement requests. Each status for a reimbursement request should have an emoji (kind of up to you to decide what emojis it'll probably get ironed out in the review process, but everything including to and past submitted to sabo status should have an emoji:
SABO_SUBMITTED
ADVISOR_APPROVED
REIMBURSED
DENIED

You'll need to make a migration to add a Message_Info[] array to reimbursement requests so that you can store the original message id when a reimbursement request is created.

Acceptance Criteria
  • A Prisma migration has been made to add a Message_Info array to the reimbursement_request model
  • The create reimbursement request endpoint has been modified to add the newly created message ids to that array whenever the slack messages for that endpoint are sent out
  • All the endpoints for editing reimbursement request statuses should be updated to react to the original message with a different emoji for each status
Proposed Solution

Look at the way this code works for change requests, it should be extremely similar, and you should be able to use a lot of the same helper methods

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.