Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine

[Seed Data] - Add at least 5 Reimbursement Requests

Open Beginner friendly
#2,292 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

back-end straightforward
Dominant language
TypeScript
Stars
36
Forks
9
Avg merge
4d 21h
Merged PRs (30d)
11

Description

Desired Changes

Epic: #976

The purpose of this ticket is to add more seed/example data of reimbursement requests in our development version of Finishline (our Github develop branch). Currently, in our development branch, we only have two reimbursement requests made in seed.ts, which makes it hard for the developers to test diverse features on the reimbursement request feature (ex. sorting reimbursement requests feature requires many reimbursement requests created in the finance page to test all the reimbursement request rows get sorted as desired).

Proposed solution:
Check how we created new reimbursement requests in the seed.ts by using ReimbursementRequestService.createReimbursementRequest service function. Define all createReimbursementRequest functions in the separate file, reimbursement-requests.seed.ts in the seed-data directory and export them to be used in the seed.ts. When you create new RRs, set the recipient to ThomasEmrax and set diverse RR fields (ex. Amount, Status, Date, etc). Run yarn prisma:reset and check all the new reimbursement requests are made in My Requests tab on the finance page from the user, Thomas.

Screenshots (as needed)

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing reimbursement request creation in seed.ts and the ReimbursementRequestService.createReimbursementRequest call. Move the create functions into seed-data/reimbursement-requests.seed.ts, export them for seed.ts, and use yarn prisma:reset to verify that at least five diverse requests for ThomasEmrax appear in the finance page's My Requests tab.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
database
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.