Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine
Finances Fixes - Finance Channel Should Get Pinged on RR Denial
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 36
- Forks
- 9
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 11
Description
Description
Currently, whenever a reimbursement request is denied, it sends a slack message to the user who submitted it. However, usually the denial notification goes to the user's email, so this slack message is redundant information. We instead wanna change the deny reimbursement request endpoint to send this message to the Finance Channel in Slack instead.
Acceptance Criteria
- Slack message is sent to the finance slack channel instead of to the submitter of the RR when an RR is denied
- The submitter of the RR is @'ed in the message
Proposed Solution
This should be as simple as changing the slack id from the user's slack id to the finance team's slack id (which can be gotten from their team model in the database)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the deny reimbursement request endpoint and the existing Slack notification path. Check the team model for the Finance team's Slack ID, then verify that a denial posts to the finance channel and mentions the reimbursement request submitter.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100