Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine
Deny Reimbursement Request Not Toasting Error
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 36
- Forks
- 9
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 11
Description
Description
In #1941 we added the ability to slack the finance channel when a reimbursement request is denied. However, when there is an error with sending the slack message, the error isn't getting correctly displayed in a toast on the frontend. This ticket is to make sure errors from this endpoint get correctly displayed in a toast on the frontend.
Acceptance Criteria
- When there is an error with the deny reimbursement request modal being submitted, it shows up in a red toast on the frontend
Proposed Solution
This may be an issue with all the NERFormModals, so you might need to change that code to fix this. You can access the deny reimbursement request modal by logging in as Vic Stone (a member of the finance team aka Justice League on our local) and clicking the deny option in the dropdown on a reimbursement request
Mocks
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by logging in as Vic Stone locally and opening the deny option on a reimbursement request. Inspect the NERFormModals error-handling path and reproduce an error while submitting the deny reimbursement request. Done means the endpoint error appears in a red frontend toast, including for the deny reimbursement modal.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100