Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine

[Refactoring] - Remove `any` type from `src\frontend\src\tests\pages\WorkPackageDetailPage\WorkPackageViewContainer\BlockedByList.test.tsx`

Open
#1,501 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

front-end straightforward
Dominant language
TypeScript
Stars
36
Forks
9
Avg merge
4d 21h
Merged PRs (30d)
11

Description

Description

This test: src\frontend\src\tests\pages\WorkPackageDetailPage\WorkPackageViewContainer\BlockedByList.test.tsx, looks like it's been broken since we've ported to the PM Dashboard V2 (currently on version 4). This ticket is to fix up this file to actually test the frontend in BlockByList

Notes

Delete the part that says it's fucked, crazy that this has been in here this long

Acceptance Criteria

Extraneous commented out code is gone, this file actually tests the code it says it does

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/frontend/src/tests/pages/WorkPackageDetailPage/WorkPackageViewContainer/BlockedByList.test.tsx and compare what it currently covers with the BlockedByList frontend after the PM Dashboard V2 migration. Remove the extraneous commented-out code, including the noted text, and update the test so it actually exercises BlockedByList. Done means the file contains no extraneous commented-out code and tests the intended component.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.