Northeastern-Electric-Racing / Northeastern-Electric-Racing/FinishLine
[Frontend] - Fix ReviewChangeRequest test
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 36
- Forks
- 9
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 11
Description
Description
In the src/frontend/src/tests/pages/ChangeRequestDetailPage/ReviewChangeRequest.test.tsx file there is a type error and a few skipped tests. We would like to fix this up to properly test the part of the frontend it was meant for.
Acceptance Criteria
- The test no longer has any type errors
- The tests pass with the current frontend code
- The tests are proper unit tests for the frontend code being tested
Proposed Solution
Fix up the use of the component being tested and ensure all necessary functions are being mocked to provide a good testing environment. Also ask questions about what part of the test is most important and how it fits in the larger scope of all tests in this project.
Mocks
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading src/frontend/src/tests/pages/ChangeRequestDetailPage/ReviewChangeRequest.test.tsx and running the existing test to identify the type error and skipped cases. Trace the component usage and required mocks in the test, then confirm that type checking passes, skipped tests are restored as proper unit tests, and the full test file passes with the current frontend code.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100