Northeastern-Electric-Racing / Northeastern-Electric-Racing/Argos
Add uploaded_by and description fields to notification rules
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5
- Forks
- 1
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 26
Description
Description
The rules table has "Uploaded By" and "Description" columns that display "-" placeholders. The backend Rule struct doesn't have these fields yet, so the frontend can't show real values.
Acceptance Criteria
- Rule struct in rule_structs.rs has uploaded_by and description fields
- add_rule persists both fields; uploaded_by is set from client identity automatically
- get_all_rules and get_all_rules_with_client_info return both fields
- Frontend table columns display real values instead of "-"
- Add Rule dialog includes a description input
- Edit Rule dialog allows editing description
Proposed Solution
Add optional String fields to the Rule struct and RulePayload in rule_structs.rs. Update add_rule in rule_controller.rs to populate uploaded_by by an optionally client set name on the Notification Rule page or by default the client identifier. On the frontend, update rules.api.ts types, the add/edit dialog forms, and remove the "-" hardcodes in rules-table.component.html.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Rule and RulePayload in rule_structs.rs, then trace add_rule, get_all_rules, and get_all_rules_with_client_info in rule_controller.rs. Update the types in rules.api.ts and the add/edit dialogs, then replace the placeholders in rules-table.component.html. Done means both fields persist and return from the backend, uploaded_by uses client identity, and the dialogs and table display the values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust, typescript
- Domain
- backend-api-design, full-stack
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100