Northeastern-Electric-Racing / Northeastern-Electric-Racing/Argos

Replace constructor injection with inject() function

Open
#560 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

angular-client straightforward
Dominant language
TypeScript
Stars
5
Forks
1
Avg merge
4d 22h
Merged PRs (30d)
26

Description

Description

Several services and components still use constructor-based injection instead of the inject() function. Example: CellService.

Acceptance Criteria
  • All constructor injection replaced with inject() calls
  • Build and lint pass
Proposed Solution

Audit all components and services for constructor parameters. Replace with private fields initialized via inject(). Remove empty constructors.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating CellService, then audit the repository's components and services for constructor parameters used for injection. Replace each constructor-based injection with private fields initialized through inject(), remove empty constructors, and verify that the build and lint checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.