Northeastern-Electric-Racing / Northeastern-Electric-Racing/Argos
Use graph page comp for accel graphs
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5
- Forks
- 1
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 26
Description
Description
A lot of functionality has been added to the graph page. However it uses a different graphing component then the widget graphs. We should really share the same component and just have more options for display type. That way we can share the same underlying logic, and improvements to that logic will be shared.
Acceptance Criteria
- The home page accel graphs use the graph screen component.
- The graph component under the graph page is now able to be used by any smaller widget.
- Graph screen still works as it did before.
- Support popping the graph out to a larger view.
Proposed Solution
Talk to Wyatt.
Mocks
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the graph screen component, the home page acceleration graphs, and the smaller widget graph implementation. Compare how each handles display types and expanded views before planning a shared interface. Done means the home page uses the graph screen component, widgets can reuse it, the graph screen retains its behavior, and graphs can pop out to a larger view.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- data-visualization, frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100