NixOS / NixOS/ofborg

Granular requiredSystemFeatures: build individual attributes in passthru.tests

Open
#678 1 comment 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
322
Forks
171
PR merge metrics
No merged PRs in 30d

Description

Currently Ofborg skips all of passthru.tests if at least one of them declares unknown requiredSystemFeatures. Instead Ofborg could filter out the unsupported tests and build the rest. Use-case: this would help avoiding custom attributes like gpuChecks in the following example, https://github.com/NixOS/nixpkgs/blob/24833cd162babe2c4d50b910d439d714fa8897d2/pkgs/development/python-modules/gpuctypes/default.nix#L88-L112

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing Ofborg's handling of passthru.tests and the requiredSystemFeatures check; the issue does not name an Ofborg file or test. Compare the behavior with the referenced nixpkgs example in pkgs/development/python-modules/gpuctypes/default.nix lines 88-112. Done means unsupported tests are filtered out while supported tests still build.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.