NixOS / NixOS/ofborg

Build `tests.*` listed as changed paths

Open
#664 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
322
Forks
171
PR merge metrics
No merged PRs in 30d

Description

OfBorg currently build packages whose expression is changed directly by the PR, but not the affected downstream packages. But we could consider building changed derivations under tests.* even if their expressions are not changed directly, as they are meant to be tested.

I'm not sure if we would like to avoid running NixOS tests (as they would be expensive) inside OfBorg. If so, it would be better to get a way to detect if a test derivation is a NixOS tests, instead of opting out everything under tests.

Update: test cases under pkgs.tests are all package tests.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing OfBorg's changed-path package selection and how it handles derivations under pkgs.tests. Confirm the behavior for package tests described in the update, then verify that a changed test derivation is built even when its expression was not directly changed; preserve the distinction from NixOS tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system, ci-cd
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.