NixOS / NixOS/ofborg

Feature Request: Warn when mass rebuild PR has wrong base

Open
#66 37 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
323
Forks
171
PR merge metrics
No merged PRs in 30d

Description

This is a small feature request I have that would be helpful for PRs.

Basically, when either 'rebuild-darwin: 501+' or 'rebuild-linux: 501+' is found, check what the base branch is. If it's based off of 'master', post a warning message from @GrahamcOfBorg explaining that it should be based off of 'staging' instead (except in rare circumstances).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace where ofborg handles the 'rebuild-darwin: 501+' and 'rebuild-linux: 501+' commands, then find how a pull request's base branch is available. Add the requested warning for builds based on 'master' and verify the warning behavior for both rebuild commands.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
ci-cd, devops, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.