NixOS / NixOS/ofborg

`ofborg-eval-check-meta` does not check `meta.hydraPlatforms` properly

Open
#580 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
323
Forks
171
PR merge metrics
No merged PRs in 30d

Description

In https://github.com/NixOS/nixpkgs/pull/140585 I accidentally wrapped the platforms in an extra list. Apparently something like

hydraPlatforms = [ [ "x86_64-linux" ] ];

is not caught by ofborg. Nixpkgs does have a line that seems like it should catch it, but clearly the effect of that line is not reaching ofborg. See

https://github.com/NixOS/nixpkgs/blob/f3d4f19fdf4b588b153433cb5d4030cbb09acbe6/pkgs/stdenv/generic/check-meta.nix#L216

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the referenced nixpkgs check-meta.nix line 216 with ofborg's metadata evaluation path. Reproduce the nested hydraPlatforms value shown in the issue and trace why it is not rejected; done means ofborg catches that malformed value.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.