NixOS / NixOS/ofborg

No review requests on modules & tests

Open
#568 2 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
322
Forks
171
PR merge metrics
No merged PRs in 30d

Description

Tested all four combinations of changes to tests/modules with person/teams set as meta.maintainers, and never got a request to review. This is quite a serious defect in our reviewing system.

https://github.com/NixOS/nixpkgs/pull/128447

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the review-request path for changes under tests/modules, using the four combinations described in the issue and the linked nixpkgs pull request as context. Check behavior with person and teams set as meta.maintainers; done means each applicable combination produces the expected review request.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.