NixOS / NixOS/ofborg

Don't request reviews on closed PRs

Open
#432 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
323
Forks
171
PR merge metrics
No merged PRs in 30d

Description

If a PR is closed before ofborg's eval is done, I don't think that a review should be requested.

Example for this: https://github.com/NixOS/nixpkgs/pull/78486

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by locating the code that requests reviews after ofborg evaluation, then reproduce the closed-before-evaluation case using the linked pull request as the example; done means no review request is made for a PR closed before evaluation completes.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.