NixOS / NixOS/ofborg

Make GitHub suggestions for fixing sha256 fields

Open
#429 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
322
Forks
171
PR merge metrics
No merged PRs in 30d

Description

Now that GitHub has suggestion review comments, a very helpful and actionable feedback can be given to PR submitters when any field (e.g. sha256) is provably wrong, with a known correct value.

Something like a bot comment with suggestion:

-   sha256 = "1gl4fzakjbhd94v1saxmr9sfzgk22m1b95jq51rxm93b2g4cixl4";
+   sha256 = "02qa6wgjpxgakg7hv4zfdlrx9k7zxa5i02wnr6y9fsv8j16sbkh1";

This comes from the experience with https://github.com/NixOS/nixpkgs/pull/77986, in which I first (knowingly) entered a wrong hash, in the hope to get a build error because of the mismatch. Which I would then track down to find the correct value in the build log.

The build finished as green soon, because of "Fixed-output derivation". Then I had various false starts supplying the expected hash.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points; start by tracing ofborg's pull-request review path and its GitHub comment integration. Done means posting an actionable GitHub suggestion when a sha256 field is provably wrong and the correct value is known.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, rust
Domain
ci-cd, devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.