NixOS / NixOS/ofborg

Feature Request: warn about manual edits of hackage-packages.nix

Open
#426 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
323
Forks
171
PR merge metrics
No merged PRs in 30d

Description

https://github.com/NixOS/nixpkgs/pull/75856

In those rare cases when it is fine to check PR, maybe use heuristic "if PR description contains This PR is test-built by Hydra at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates".

Or maybe it should have label: hackage-packages-update.

This is not a single case. Just searching "do not edit hackage-packages.nix" gives 32 PRs https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+do+not+edit+hackage-packages.nix+is%3Aclosed

Maybe add a link to one of @peti's videos where whole process of Haskell fixes is described. For example, https://www.twitch.tv/videos/520997983

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked nixpkgs pull request and searching the ofborg repository for existing pull-request checks or references to hackage-packages.nix. The issue proposes several detection and warning approaches but names no file, entry point, or test, so the completion criteria need to be settled before implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.