NixOS / NixOS/ofborg

Detect package better for PRs that don't touch default.nix

Open
#383 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
323
Forks
171
PR merge metrics
No merged PRs in 30d

Description

When I submit a PR for a bundlerApp package where all I did was modify the Gemfile.lock and gemset.nix files, ofborg doesn't detect the package and therefore doesn't label my PR correctly (e.g. it's missing 8.has: package (update) and 11.by: package-maintainer).

Example PR: https://github.com/NixOS/nixpkgs/pull/66251

I'm not actually sure what logic ofborg uses to detect the packages modified by the PR, so I don't know what the best approach for teaching it about this scenario. One simple possibility would be if the PR title or any commit in the PR follows the format "attrname: …" then check that attribute and see if anything in it was modified by the PR. That simple check would handle the above PR, because the cocoapods-beta attribute is a derivation that references both Gemfile.lock and gemset.nix (and in fact its version attribute is also changed since that comes from gemset.nix).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing ofborg's package-detection logic for pull requests and compare it with example PR #66251. Inspect how changes to Gemfile.lock and gemset.nix are associated with the cocoapods-beta attribute, then verify that the PR receives the package update and package-maintainer labels when detection succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.