NixOS / NixOS/ofborg

Evaluate on platforms the packages are buildable before scheduling the builds

Open
#352 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
323
Forks
171
PR merge metrics
No merged PRs in 30d

Description

An example for the problem is the following PR: https://github.com/NixOS/nixpkgs/pull/59449/checks?check_run_id=101239188

It seems as the darwin machine was quite busy this morning, so it took a while until avidemux was evaluated on Darwin. When the build was started, it didn't build as avidemux isn't supported on Darwin.

I have to admit that I forgot to check the meta section before (then I would've merged right away), but I still think that in terms of UX it's better to only schedule builds on supported platforms (or to abort those immediately rather than queuing those and wait for a free build slot on nix.ci).

As I'm not such an experienced Rust developer, I can't promise that I'll provide a fix in the next time unfortunately, so if anybody else wants to take over, fell free :)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked nixpkgs PR checks and the ofborg code responsible for evaluating packages and scheduling platform builds. Confirm how package platform support is represented, then verify that unsupported platforms are not queued or are aborted immediately, using the relevant existing checks if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system, ci-cd
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.