versionCheckHook: cannot set empty `versionCheckProgramArg`
Nobody has claimed this yet.
- Dominant language
- Nix
- Stars
- 26.2k
- Forks
- 20.1k
- PR merge metrics
- PR metrics pending
Description
As the title says. Setting versionCheckProgramArg = ""; or versionCheckProgramArg = [ ]; will make the hook try the default --version and --help args instead of just without the args.
Actually I don't really understand what the purpose of separating versionCheckProgram and versionCheckProgramArg into two arguments is. I think versionCheckProgram = "${placeholder "out"}/bin/foo --version"; or versionCheckProgram = [ "${placeholder "out"}/bin/foo" "--version" ]; is better.
CC @doronbehar
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the versionCheckHook implementation and its existing tests, then reproduce the behavior with an empty versionCheckProgramArg string and list. Done means either form invokes the program without the default --version or --help arguments, with regression coverage for both cases.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100