NixOS / NixOS/nix.dev

Sphinx anchor linkcheck fails for GitHub links to Markdown files

Open
#631 2 comments 0 reactions 1 assignee View on GitHub

@yukiisbored is already working on this.

Since Jul 7, 2023.

bug site
Dominant language
Nix
Stars
4k
Forks
339
Avg merge
2d 11h
Merged PRs (30d)
7

Description

Observations

make linkcheck fails because Sphinx linkcheck coudn't find the "user-content-vision" anchor on https://github.com/NixOS/nix.dev/blob/master/CONTRIBUTING.md#user-content-vision which causes CI to fail.

Warning, treated as error:
/home/runner/work/nix.dev/nix.dev/source/contributing/documentation.md:57:broken link: https://github.com/NixOS/nix.dev/blob/master/CONTRIBUTING.md#user-content-vision (Anchor 'user-content-vision' not found)

Taken from https://github.com/NixOS/nix.dev/actions/runs/5479501955/jobs/9981419507.

Problem

It appears GitHub has made the file/markdown viewer require JavaScript as seen below:

Capture d’écran 2023-07-07 à 17 00 57

Approaches

  • Disable linkcheck anchor checks
    • Could allow for linkrot where the content is deleted from the page.
  • Ignore GitHub links altogether
    • Linking to Markdown files on GitHub is a pretty common use case.
  • Ignore this link
    • CI will fail if a GitHub markdown link with anchor is added.
  • Find an alternative to builtin linkcheck

Willing to help?

Yes

Priorities

Add 👍 to issues you find important.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.